Skip to content

Comments

governance: harden resume identity binding and unknown discovery defaults#60

Merged
davidahmann merged 1 commit intomainfrom
codex/pr59-comment-followups
Feb 22, 2026
Merged

governance: harden resume identity binding and unknown discovery defaults#60
davidahmann merged 1 commit intomainfrom
codex/pr59-comment-followups

Conversation

@davidahmann
Copy link
Collaborator

Problem

  • Resume flow allowed a caller to pass a different --identity than the job's bound identity.
  • Omitted target discovery_method normalized to empty, so policy rules matching discovery_method: [unknown] could miss.
  • Digest normalization changes for omitted discovery metadata were not documented for approval-token operators.

Changes

  • Preserve bound job identity on resume and reject mismatches with explicit identity binding mismatch error.
  • Normalize omitted discovery_method to unknown during intent normalization.
  • Add tests for identity mismatch enforcement and unknown discovery matching.
  • Update integration/scenario fixtures impacted by deterministic digest change.
  • Add upgrade notes to changelog and approval runbook for token reminting after digest normalization change.

Validation

  • ./gait doctor --json
  • make prepush-full
  • go test ./...
  • gait gate eval --policy <tmp_policy.yaml> --intent <tmp_intent.json> --json (validated match on discovery_method: [unknown])

@davidahmann davidahmann merged commit 59adce1 into main Feb 22, 2026
7 checks passed
@davidahmann davidahmann deleted the codex/pr59-comment-followups branch February 22, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant